Fix entire page disapearing when theme buttons double-clicked #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks seem to be failing because of the theme === empty string comparison. The only way I can see to fix that is to make "" be a part of the Theme type. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When theme buttons (light mode, dark mode, and system theme buttons) are double-clicked, they make the entire page suddenly disappear.
Temporarily fixed by not setting the style of the page if what it's supposed to become is a blank string (which is happening, despite type Theme being one of 'light', 'dark', or 'system').
The cause of this happening is currently unknown (to me, at least)