Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: optimize attrhash_cmp calls #18097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bgpd: optimize attrhash_cmp calls #18097

wants to merge 1 commit into from
+15 −19

Conversation

louis-6wind
Copy link
Contributor

Only call attrhash_cmp when necessary.

@louis-6wind
bgpd: optimize attrhash_cmp calls
234b8aa 
Only call attrhash_cmp when necessary.

Signed-off-by: Louis Scalbert <[email protected]>
@frrbot frrbot bot added the bgp label Feb 11, 2025
@riw777 riw777 self-requested a review February 11, 2025 16:34
@donaldsharp
Copy link
Member

This is a good idea.

@louis-6wind
Copy link
Contributor Author

ci:rerun

1 similar comment
@louis-6wind
Copy link
Contributor Author

ci:rerun

riw777
riw777 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@louis-6wind
Copy link
Contributor Author

ci:rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
bgp master size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-6wind @donaldsharp @riw777