Bgp ecommlist count #18159
Open
Bgp ecommlist count #18159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
bgp_ecommlist_count
branch
from
8d56860 to
810deaf
Compare
ton31337
reviewed
Feb 14, 2025
bgpd/bgp_clist.c
Outdated
| uint32_t i; | ||
|
|
||
| for (i = 0; i < ecom->size; i++) { | ||
| ptr = ecom->val + (i * ECOMMUNITY_SIZE); |
There was a problem hiding this comment.
We should handle IPv6-specific extended communities also. Thus ecom->unit_size should be used instead.
bgpd/bgp_ecommunity.c
Outdated
| @@ -1168,8 +1168,10 @@ char *ecommunity_ecom2str(struct ecommunity *ecom, int format, int filter) | |||
| bool unk_ecom = false; | |||
| memset(encbuf, 0x00, sizeof(encbuf)); | |||
|
|
|||
| if (number != -1 && (uint32_t)number != i) | |||
There was a problem hiding this comment.
I added some more information, and renamed it to index.
|
|
||
| path = (struct bgp_path_info *)object; | ||
|
|
||
| piextcomm = bgp_attr_get_ecommunity(path->attr); |
There was a problem hiding this comment.
Please include also IPv6-address specific extended communities...
doc/user/bgp.rst
Outdated
| @@ -2907,7 +2907,13 @@ Extended Community Lists | |||
| Note that all extended community lists shares a single name space, so it's | |||
| not necessary to specify their type when creating or destroying them. | |||
|
|
|||
| .. clicmd:: show bgp extcommunity-list [NAME detail] | |||
| .. clicmd:: match community-limit (0-65535) | |||
There was a problem hiding this comment.
Why do we need this duplicate? We already have this documented.
There was a problem hiding this comment.
you re right. simplifying it.
pguibert6WIND
force-pushed
the
bgp_ecommlist_count
branch
2 times, most recently
from
4e2da9d to
336f122
Compare
pguibert6WIND
force-pushed
the
bgp_ecommlist_count
branch
2 times, most recently
from
7200c52 to
a46d82e
Compare
ton31337
reviewed
Feb 26, 2025
doc/user/bgp.rst
Outdated
| @@ -2918,7 +2918,20 @@ Extended Community Lists | |||
| BGP Extended Communities in Route Map | |||
| """"""""""""""""""""""""""""""""""""" | |||
|
|
|||
| .. clicmd:: match extcommunity WORD | |||
| .. clicmd:: match extcommunity WORD [exact-match] | |||
ton31337
reviewed
Feb 26, 2025
| .. clicmd:: match extcommunity WORD | ||
| .. clicmd:: match extcommunity WORD [exact-match] | ||
|
|
||
| This command perform match to BGP updates using extended community list WORD. |
ton31337
reviewed
Feb 26, 2025
doc/user/bgp.rst
Outdated
|
|
||
| This command perform match to BGP updates using extended community list WORD. | ||
| When the one of BGP extended communities value match to the one of the extended | ||
| communities value in community list, it is match. When `exact-match` keyword is |
There was a problem hiding this comment.
To highlight, we should use double ticks.
Add a mechanism in route-map to filter out route-map which have a list of extended communities greater than the given number. Signed-off-by: Philippe Guibert <[email protected]>
It should be possible to configure the community-limit count to 0. Fixes: f19b866 ("bgpd: add 'match community-count' command to restrict comm count") Signed-off-by: Philippe Guibert <[email protected]>
The exact-match and the any options are missing for the extended communities. Add missing options that are present on the match operations for communities and large-communities. > route-map rmap permit 1 > match extcommunity 1 > exit > ! > route-map rmap permit 2 > match extcommunity 2 any > exit > ! > route-map rmap permit 3 > match extcommunity 3 exact-match > exit Signed-off-by: Philippe Guibert <[email protected]>
Add a test suite that checks that it is possible to filter out BGP updates based on the extcommunity-list match operation of the route-map. Check also the extcommunity-limit option. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
bgp_ecommlist_count
branch
from
a46d82e to
1879a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extensions in route-map for handling extended community-list in match operations: