babeld: Add Flags checking in Hello TLV #18212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zmw12306 <[email protected]>
zmw12306
force-pushed
the
helloTLVFlag
branch
from
f62fec9 to
9f18747
Compare
|
can you put your analysis about what is going on in the actual commit itself? |
This commit checks whether it is a valid MULTICAST hello, if not, the code logs a debug message and stops processing the packet. Do you want me to add this to the commit message? |
Yes, that would be great. |
riw777
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 8966: https://www.rfc-editor.org/rfc/rfc8966#name-hello
X: all other bits MUST be sent as 0 and silently ignored on reception
This means the Flags field could either be BABEL_UNICAST_HELLO 0x8000 or BABEL_MULTICAST_HELLO 0x0000, otherwise it is an invalid packet.