ripd: fix ip rip send/receive version command #18217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
7510df4 to
36117a6
Compare
Shbinging
changed the title
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
36117a6 to
c932146
Compare
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
c932146 to
76c95ff
Compare
OK，I added the test rip_send_recv_version |
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
76c95ff to
24e0819
Compare
ton31337
reviewed
Feb 21, 2025
Yes, we have command Besides, we have command |
ton31337
reviewed
Feb 26, 2025
| IP_STR | ||
| "Routing Information Protocol\n" | ||
| "Advertisement reception\n" | ||
| "Version control\n" | ||
| "RIP version 1\n" | ||
| "RIP version 2\n" | ||
| "RIP version 1&2\n" |
There was a problem hiding this comment.
From my editor this line 747 and 754 are both aligned
ton31337
reviewed
Feb 26, 2025
| # SPDX-License-Identifier: ISC | ||
|
|
||
| # Copyright (c) 2023 by | ||
| # Donatas Abraitis <[email protected]> |
ton31337
reviewed
Feb 26, 2025
| #!/usr/bin/env python | ||
| # SPDX-License-Identifier: ISC | ||
|
|
||
| # Copyright (c) 2023 by |
ton31337
reviewed
Feb 26, 2025
| # | ||
|
|
||
| """ | ||
| Test if RIP `passive-interface default` and `no passive-interface IFNAME` |
ton31337
reviewed
Feb 26, 2025
| tgen.stop_topology() | ||
|
|
||
|
|
||
| import re |
ton31337
reviewed
Feb 26, 2025
|
|
||
|
|
||
| import re | ||
| def getConfOfInterface(i_name, text): |
There was a problem hiding this comment.
Please use snake_case pattern for function names.
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
24e0819 to
bf80a25
Compare
Now the vtysh will reject illegal command `ip rip send/receive version 2 1`, instead accept command `ip rip send/receive version 1 2` as shown in doc. Add topotest `rip_send_recv_version` test. Signed-off-by: Shbinging <[email protected]>
Shbinging
force-pushed
the
fix_ip_rip_version
branch
from
bf80a25 to
58f9bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the vtysh will reject illegal command
ip rip send/receive version 2 1, instead accept commandip rip send/receive version 1 2as shown in doc.Add topotest
rip_send_recv_versiontest.Signed-off-by: Shbinging [email protected]