feat: add post #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRSgit
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Simple & quick implementation, I like it!
You can have a look at solution by Adam - he has added "variable handling" to the mutate method. Just to know that it is possible :)
In this case it wasn't required and your solution is much cleaner, so good job!
I'd say it would be nice to refetch user data right after you add new user (so it's visible that something was added) - also, you can add error handling using error variable.
But these weren't required parts of the exercise, so it's okay :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.