Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate that an expressions uses metric name #33

Closed
tizki opened this issue Nov 23, 2023 · 1 comment · Fixed by #36
Closed

validate that an expressions uses metric name #33

tizki opened this issue Nov 23, 2023 · 1 comment · Fixed by #36
Labels
enhancement New feature or request

Comments

@tizki
Copy link
Contributor

tizki commented Nov 23, 2023

very nice project!
I want to be able to validate the the expressions of alerting rules use metric name (to avoid getting results from ALERT / ALERTS_FOR_STATE for example).
is it possible to do it with the existing validators? if not, any chance it can be added?
Thanks!
@FUSAKLA FUSAKLA added the enhancement New feature or request label Nov 23, 2023
@FUSAKLA
Copy link
Owner

FUSAKLA commented Nov 23, 2023 •
edited
Loading

Hi and thank you!

Unfortunately current validators cannot test that, but it should be quite easy to add such validator and sounds reasonable to me 👍

I'll take a look at it when I find a free while, or feel free to send PR if you want to speed things up

@FUSAKLA FUSAKLA mentioned this issue Dec 4, 2023
Merged
@FUSAKLA FUSAKLA linked a pull request Dec 5, 2023 that will close this issue
Add metric name validation #36
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metric name validation tizki/promruval
2 participants
@tizki @FUSAKLA