Add validator to forbid usage of some metrics in rules #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUSAKLA
force-pushed
the
fus-expr-uses-metric-name
branch
from
b2e0d43
to
a0d1a83
Compare
|
@tizki do you think you could try it out if that makes sense this way? |
|
Hi, |
|
Oh, I'm sorry to hear that :/ It looks like we both went duplicating the effort. |
|
oh, I didn't notice your PR. |
|
I just reviewed your PR and in the end our PRs do not overlap, because I misunderstood what you requested 🎉 😄 This PR adds a validator to forbid using some metrics in alerts/rules |
FUSAKLA
changed the title
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
FUSAKLA
force-pushed
the
fus-expr-uses-metric-name
branch
from
31908a2
to
8618437
Compare
Signed-off-by: Martin Chodur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # 33So it was misunderstanding, this does not resolve the issue #33, it adds other validator but still valid :)