chore: allow whitespace after comma in ignore validations comments #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichalek132
commented
Oct 7, 2024
jmichalek132
commented
Oct 7, 2024
FUSAKLA
reviewed
Oct 7, 2024
FUSAKLA
reviewed
Oct 7, 2024
FUSAKLA
reviewed
Oct 7, 2024
FUSAKLA
reviewed
Oct 7, 2024
FUSAKLA
reviewed
Oct 7, 2024
FUSAKLA
approved these changes
Oct 7, 2024
|
The CI is failing, would you please try running |
No worries thanks for the feedback. |
Oh could you please run it, I am using WSL2 which golangci-lint seems to have some issues with xxpxxxxp/intellij-plugin-golangci-lint#71. |
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common practice to have whitespaces in comma separated lists, however since we don't remove them in the implementation of the comment / annotation for disabling validations, the whitespaces causes the the name of the validations to not match.
This draft PR provides a file for a test case and adds whitespace trimming for the validation name.