Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic when validation unsupported file type #95

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: panic when validation unsupported file type #95

merged 1 commit into from
Oct 31, 2024

Conversation

FUSAKLA
Copy link
Owner

@FUSAKLA FUSAKLA commented Oct 31, 2024 •
edited
Loading

fixes #94

  • avoid the panic
  • rollback to the former behavior when all file types are validated and treated as rule files yaml regardless of the extension (only exception is .jsonnet)
  • add e2e tests to cover such case

Signed-off-by: Martin Chodur [email protected]

@FUSAKLA
fix: panic when validation unsupported file type and rollbac to previ…
dbb8301 
…ous behavior with unsupported file types

fixes #94

Signed-off-by: Martin Chodur <[email protected]>
@FUSAKLA FUSAKLA force-pushed the fus-ratty-nightingale branch from 13a229f to dbb8301 Compare October 31, 2024 22:19
@FUSAKLA FUSAKLA merged commit 5e707fc into master Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when rule files are not yaml yml or jsonnnet
1 participant
@FUSAKLA