Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for UTF-8 and new UTF-8 related validators #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add support for UTF-8 and new UTF-8 related validators #96

wants to merge 2 commits into from

Conversation

FUSAKLA
Copy link
Owner

@FUSAKLA FUSAKLA commented Oct 31, 2024 •
edited
Loading

fixes #88

  • enable UTF-8 support in label and metric names by default
  • add validator to disallow using the UTF-8 (this should be used as a default for now, UTF-8 support is still in early stages in Prometheus)

this change will probably result into new major version, since the UTF-8 support might be breaking

Signed-off-by: Martin Chodur [email protected]

@FUSAKLA
Copy link
Owner Author

FUSAKLA commented Oct 31, 2024

@jmichalek132 would you give it a try? 🙏

@FUSAKLA
fix: e2e tests
1030bcd 
Signed-off-by: Martin Chodur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for utf-8 🎉🎉🎉🎉🎉
1 participant
@FUSAKLA