Query implementation skeleton

.github/CODEOWNERS

@@ -758,7 +758,6 @@
 ################
 /eng/                                                @hallipr @weshaggard @benbp @JimSuplizio
 /eng/code-quality-reports/                           @mssfang @JonathanGiles
-/eng/jacoco-test-coverage/                           @srnagar @JonathanGiles
 /eng/spotbugs-aggregate-report/                      @srnagar @JonathanGiles
 /eng/mgmt/                                           @weidongxu-microsoft @haolingdong-msft @XiaofeiCao @arthurma1978 @hallipr @weshaggard @benbp @JimSuplizio
 /eng/versioning/                                     @alzimmermsft @samvaity @g2vinay @JimSuplizio

.vscode/cspell.json

@@ -127,6 +127,7 @@
     "sdk/core/azure-xml/**",
     "sdk/cosmos/azure-cosmos-dotnet-benchmark/**",
     "sdk/core/azure-core-tracing-opentelemetry/**",
+    "sdk/core/azure-core-tracing-opentelemetry-samples/**",
     "sdk/cosmos/azure-cosmos-benchmark/**",
     "sdk/core/azure-json-gson/**",
     "sdk/cosmos/azure-cosmos-spark_3-1_2-12/**",
@@ -330,6 +331,7 @@
     "Mockito",
     "Mordor",
     "mosca",
+    "mpga",
     "msal",
     "msix",
     "MSRC",
@@ -338,6 +340,7 @@
     "odata",
     "ODBC",
     "okhttp",
+    "OTLP",
     "OLTP",
     "onboarded",
     "Onco",
@@ -1038,6 +1041,12 @@
         "Pdev"
       ]
     },
+    {
+      "filename": "sdk/spring/spring-cloud-azure-starter-monitor/**.md",
+      "words": [
+        "Djava"
+      ]
+    },
     {
       "filename": "sdk/purview/azure-analytics-purview-sharing/**",
       "words": [

common/smoke-tests/pom.xml

@@ -118,7 +118,7 @@
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-cosmos</artifactId>
-      <version>4.49.0</version> <!-- {x-version-update;com.azure:azure-cosmos;dependency} -->
+      <version>4.50.0</version> <!-- {x-version-update;com.azure:azure-cosmos;dependency} -->
     </dependency>
 
     <dependency>
@@ -130,25 +130,25 @@
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-security-keyvault-secrets</artifactId>
-      <version>4.6.5</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;dependency} -->
+      <version>4.7.0</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;dependency} -->
     </dependency>
 
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-messaging-eventhubs</artifactId>
-      <version>5.15.8</version> <!-- {x-version-update;com.azure:azure-messaging-eventhubs;dependency} -->
+      <version>5.16.0</version> <!-- {x-version-update;com.azure:azure-messaging-eventhubs;dependency} -->
     </dependency>
 
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-messaging-eventhubs-checkpointstore-blob</artifactId>
-      <version>1.16.9</version> <!-- {x-version-update;com.azure:azure-messaging-eventhubs-checkpointstore-blob;dependency} -->
+      <version>1.17.0</version> <!-- {x-version-update;com.azure:azure-messaging-eventhubs-checkpointstore-blob;dependency} -->
     </dependency>
 
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-storage-blob</artifactId>
-      <version>12.23.1</version> <!-- {x-version-update;com.azure:azure-storage-blob;dependency} -->
+      <version>12.24.0</version> <!-- {x-version-update;com.azure:azure-storage-blob;dependency} -->
     </dependency>
 
     <dependency>

eng/code-quality-reports/src/main/java/com/azure/tools/checkstyle/checks/StepVerifierCheck.java

@@ -0,0 +1,76 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+package com.azure.tools.checkstyle.checks;
+
+import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
+import com.puppycrawl.tools.checkstyle.api.DetailAST;
+import com.puppycrawl.tools.checkstyle.api.FullIdent;
+import com.puppycrawl.tools.checkstyle.api.TokenTypes;
+
+/**
+ * Ensures that test code doesn't use {@code StepVerifier.setDefaultTimeout}.
+ * <p>
+ * This configures a default timeout used by all {@code StepVerifier} calls, which can lead to flaky tests as this may
+ * affect other tests.
+ */
+public class StepVerifierCheck extends AbstractCheck {
+    private static final String SET_DEFAULT_TIMEOUT = "setDefaultTimeout";
+    private static final String FULLY_QUALIFIED = "reactor.test.StepVerifier.setDefaultTimeout";
+    private static final String METHOD_CALL = "StepVerifier.setDefaultTimeout";
+
+    static final String ERROR_MESSAGE = "Do not use StepVerifier.setDefaultTimeout as it can affect other tests. "
+                                        + "Instead use expect* methods on StepVerifier and use verify(Duration) to "
+                                        + "set timeouts on a test-by-test basis.";
+
+    private boolean hasStaticImport;
+
+    @Override
+    public int[] getDefaultTokens() {
+        return new int[]{
+            TokenTypes.METHOD_CALL,
+            TokenTypes.STATIC_IMPORT
+        };
+    }
+
+    @Override
+    public int[] getAcceptableTokens() {
+        return getDefaultTokens();
+    }
+
+    @Override
+    public int[] getRequiredTokens() {
+        return getDefaultTokens();
+    }
+
+    @Override
+    public void init() {
+        super.init();
+        hasStaticImport = false;
+    }
+
+    @Override
+    public void destroy() {
+        super.destroy();
+        hasStaticImport = false;
+    }
+
+    @Override
+    public void visitToken(DetailAST ast) {
+        if (ast.getType() == TokenTypes.STATIC_IMPORT) {
+            // Compare if the static import is for StepVerifier.setDefaultTimeout
+            hasStaticImport = FULLY_QUALIFIED.equals(
+                FullIdent.createFullIdent(ast.getFirstChild().getNextSibling()).getText());
+        } else {
+            // Compare the method call against StepVerifier.setDefaultTimeout or setDefaultTimeout if there is a static
+            // import for StepVerifier.setDefaultTimeout
+            FullIdent fullIdent = FullIdent.createFullIdentBelow(ast);
+            if (hasStaticImport && SET_DEFAULT_TIMEOUT.equals(fullIdent.getText())) {
+                log(ast.getLineNo(), fullIdent.getColumnNo(), ERROR_MESSAGE);
+            } else if (METHOD_CALL.equals(fullIdent.getText())) {
+                log(ast.getLineNo(), fullIdent.getColumnNo(), ERROR_MESSAGE);
+            } else if (FULLY_QUALIFIED.equals(fullIdent.getText())) {
+                log(ast.getLineNo(), fullIdent.getColumnNo(), ERROR_MESSAGE);
+            }
+        }
+    }
+}

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

@@ -113,7 +113,10 @@
 
   <!-- AzureSpringMonitorConfig defines Spring bean used in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java-->
   <suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck"
-            files="com.azure.monitor.applicationinsights.spring.AzureSpringMonitorConfig.java"/>
+            files="com.azure.monitor.applicationinsights.spring.AzureSpringMonitorAutoConfig.java"/>
+  <!-- To be able to return a configured loggger for self-diagnostics and use it as a Spring bean-->
+  <suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck"
+            files="com.azure.monitor.applicationinsights.spring.selfdiagnostics.*Log.*Config.*.java"/>
 
   <!-- For the Application Insights Spring Boot starter for Spring native, users have only to declare the starter dependency. Users won't manipulate the Java classes of this Spring Boot starter. -->
   <suppress checks="Javadoc" files=".*[/\\]com[/\\]azure[/\\]monitor[/\\]applicationinsights[/\\]spring[/\\]*"/>
@@ -434,6 +437,7 @@ the main ServiceBusClientBuilder. -->
 
   <!-- Can be removed after https://github.com/Azure/azure-sdk-for-java/issues/36609 -->
   <suppress checks="com.azure.tools.checkstyle.checks.(GoodLoggingCheck|ThrowFromClientLoggerCheck|UseCaughtExceptionCauseCheck)" files="com.azure.monitor.applicationinsights.spring.OpenTelemetryVersionCheckRunner.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.(GoodLoggingCheck|ThrowFromClientLoggerCheck|UseCaughtExceptionCauseCheck)" files="com.azure.monitor.applicationinsights.spring.selfdiagnostics.*.java"/>
 
   <!-- ExternalDependencyExposedCheck: Spring will directly use classes from spring dependencies in methods-->
   <suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck" files=".*[/\\]com[/\\]azure[/\\]spring[/\\].*"/>

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle.xml

@@ -408,5 +408,7 @@ page at http://checkstyle.sourceforge.net/config.html -->
     <!-- CUSTOM CHECKS -->
     <!-- Ensures caught exceptions are included as exception cause in subsequently thrown exception -->
     <module name="com.azure.tools.checkstyle.checks.UseCaughtExceptionCauseCheck"/>
+
+    <module name="com.azure.tools.checkstyle.checks.StepVerifierCheck"/>
   </module>
 </module>

eng/code-quality-reports/src/main/resources/revapi/revapi.json

@@ -299,6 +299,19 @@
           "code": "java.annotation.added",
           "new": "class com.azure.cosmos.models.ChangeFeedProcessorItem",
           "justification": "Modifies the type of changeFeedMetaData from ChangeFeedMetaData to JsonNode."
+        },
+        {
+          "ignore": true,
+          "code": "java.field.addedStaticField",
+          "new": "field com.azure.data.schemaregistry.SchemaRegistryVersion.V2022_10",
+          "justification": "Another version of Schema Registry API released."
+        },
+        {
+          "regex": true,
+          "ignore": true,
+          "code": "java.field.addedStaticField",
+          "new": "field com\\.azure\\.data\\.schemaregistry\\.models\\.SchemaFormat\\.(CUSTOM|JSON)",
+          "justification": "Additional schema formats are supported by Schema Registry."
         }
       ]
     }

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -462,8 +462,9 @@
   <!-- The casting problems do not exist in Azure use cases -->
   <Match>
     <Or>
+      <Class name="com.azure.core.implementation.MethodHandleReflectiveInvoker"/>
+      <Class name="com.azure.core.implementation.ReflectionUtilsMethodHandle"/>
       <Class name="com.azure.core.implementation.TypeUtil"/>
-      <Class name="com.azure.core.implementation.ReflectionUtils"/>
     </Or>
     <Bug pattern="BC_UNCONFIRMED_CAST"/>
   </Match>
@@ -2697,4 +2698,18 @@
     <Method name="transfer"/>
     <Bug pattern="NP_NULL_ON_SOME_PATH"/>
   </Match>
+
+   <!-- Returning a new copy of the object is not necessary -->
+  <Match>
+    <Class name="~com\.azure\.ai\.openai\.models\.(AudioTranscriptionOptions|AudioTranslationOptions)"/>
+    <Method name="&lt;init&gt;"/>
+    <Bug pattern="EI_EXPOSE_REP2"/>
+  </Match>
+
+  <!-- False positive, it throws an IllegalArgumentException if non-exist method parameter type passed.-->
+  <Match>
+    <Class name="com.azure.ai.openai.implementation.MultipartDataHelper"/>
+    <Method name="serializeRequest"/>
+    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
+  </Match>
 </FindBugsFilter>

eng/code-quality-reports/src/test/java/com/azure/tools/checkstyle/checks/StepVerifierCheckTest.java

@@ -0,0 +1,94 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+package com.azure.tools.checkstyle.checks;
+
+import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
+import com.puppycrawl.tools.checkstyle.Checker;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.util.Arrays;
+
+public class StepVerifierCheckTest extends AbstractModuleTestSupport {
+    private Checker checker;
+
+    @BeforeEach
+    public void prepare() throws Exception {
+        checker = createChecker(createModuleConfig(StepVerifierCheck.class));
+    }
+
+    @AfterEach
+    public void cleanup() {
+        checker.destroy();
+    }
+
+    @Override
+    protected String getPackageLocation() {
+        return "com/azure/tools/checkstyle/checks/StepVerifierCheck";
+    }
+
+    @Test
+    public void noStepVerifierSetDefaultTimeout() throws Exception {
+        File file = TestUtils.createCheckFile("publicClassImplementsPublicApi", Arrays.asList(
+            "package com.azure;",
+            "public class MyTestClass {",
+            "}"
+        ));
+
+        verify(checker, new File[]{file}, file.getAbsolutePath());
+    }
+
+    @Test
+    public void stepVerifierSetDefaultTimeout() throws Exception {
+        File file = TestUtils.createCheckFile("publicClassImplementsPublicApi", Arrays.asList(
+            "package com.azure;",
+            "public class MyTestClass {",
+            "    public void test() {",
+            "        StepVerifier.setDefaultTimeout(Duration.ofSeconds(10));", // line 4, column 9
+            "    }",
+            "}"
+        ));
+
+        String[] expected = new String[] {
+            String.format("%d:%d: %s", 4, 9, StepVerifierCheck.ERROR_MESSAGE)
+        };
+        verify(checker, new File[]{file}, file.getAbsolutePath(), expected);
+    }
+
+    @Test
+    public void stepVerifierStaticImportSetDefaultTimeout() throws Exception {
+        File file = TestUtils.createCheckFile("publicClassImplementsPublicApi", Arrays.asList(
+            "package com.azure;",
+            "import static reactor.test.StepVerifier.setDefaultTimeout;",
+            "public class MyTestClass {",
+            "    public void test() {",
+            "        setDefaultTimeout(Duration.ofSeconds(10));", // line 5, column 9
+            "    }",
+            "}"
+        ));
+
+        String[] expected = new String[] {
+            String.format("%d:%d: %s", 5, 9, StepVerifierCheck.ERROR_MESSAGE)
+        };
+        verify(checker, new File[]{file}, file.getAbsolutePath(), expected);
+    }
+
+    @Test
+    public void stepVerifierFullyQualifierSetDefaultTimeout() throws Exception {
+        File file = TestUtils.createCheckFile("publicClassImplementsPublicApi", Arrays.asList(
+            "package com.azure;",
+            "public class MyTestClass {",
+            "    public void test() {",
+            "        reactor.test.StepVerifier.setDefaultTimeout(Duration.ofSeconds(10));", // line 4, column 9
+            "    }",
+            "}"
+        ));
+
+        String[] expected = new String[] {
+            String.format("%d:%d: %s", 4, 9, StepVerifierCheck.ERROR_MESSAGE)
+        };
+        verify(checker, new File[]{file}, file.getAbsolutePath(), expected);
+    }
+}

eng/common/pipelines/templates/steps/sparse-checkout.yml

@@ -29,7 +29,7 @@ steps:
             if (!$dir) {
               $dir = "./$($repository.Name)"
             }
-            New-Item $dir -ItemType Directory -Force
+            New-Item $dir -ItemType Directory -Force | Out-Null
             Push-Location $dir
 
             if (Test-Path .git/info/sparse-checkout) {
@@ -70,9 +70,14 @@ steps:
 
             # sparse-checkout commands after initial checkout will auto-checkout again
             if (!$hasInitialized) {
-              Write-Host "git -c advice.detachedHead=false checkout $($repository.Commitish)"
+              # Remove refs/heads/ prefix from branch names
+              $commitish = $repository.Commitish -replace '^refs/heads/', ''
+
+              # use -- to prevent git from interpreting the commitish as a path
+              Write-Host "git -c advice.detachedHead=false checkout $commitish --"
+
               # This will use the default branch if repo.Commitish is empty
-              git -c advice.detachedHead=false checkout $($repository.Commitish)
+              git -c advice.detachedHead=false checkout $commitish --
             } else {
               Write-Host "Skipping checkout as repo has already been initialized"
             }

eng/common/scripts/Get-BuildSourceDescription.ps1

@@ -0,0 +1,24 @@
+param(
+  [string]$Variable,
+  [switch]$IsOutput
+)
+
+$repoUrl = $env:BUILD_REPOSITORY_URI
+$sourceBranch = $env:BUILD_SOURCEBRANCH
+
+$description = "[$sourceBranch]($repoUrl/tree/$sourceBranch)" 
+if ($sourceBranch -match "^refs/heads/(.+)$") {
+    $description = "Branch: [$($Matches[1])]($repoUrl/tree/$sourceBranch)"
+} elseif ($sourceBranch -match "^refs/tags/(.+)$") {
+    $description = "Tag: [$($Matches[1])]($repoUrl/tree/$sourceBranch)"
+} elseif ($sourceBranch -match "^refs/pull/(\d+)/(head|merge)$") {
+    $description = "Pull request: $repoUrl/pull/$($Matches[1])"
+}
+
+if ($IsOutput) {
+  Write-Host "Setting output variable '$Variable' to '$description'"
+  Write-Host "##vso[task.setvariable variable=$Variable;isoutput=true]$description"
+} else {
+  Write-Host "Setting variable '$Variable' to '$description'"
+  Write-Host "##vso[task.setvariable variable=$Variable]$description"
+}