Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of repeated elements #107

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

NebelNidas
Copy link
Collaborator

@NebelNidas NebelNidas commented Aug 23, 2024

Every class entry in a mapping file is now guaranteed to result in a visitClass call. For flat mapping formats, element mappings which contain their parent class' name now only call visitClass when new data becomes available. Same for method mappings in formats that support parameters/variables.

@NebelNidas NebelNidas added this to the 0.7.0 milestone Aug 23, 2024
@NebelNidas NebelNidas marked this pull request as ready for review August 25, 2024 15:10
@NebelNidas NebelNidas merged commit ed68729 into FabricMC:dev Aug 26, 2024
3 checks passed
@NebelNidas NebelNidas deleted the fix-handling-of-repeated-elements branch August 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants