Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23w44a commands #3716

Merged
merged 5 commits into from
Nov 2, 2023
Merged

23w44a commands #3716

merged 5 commits into from
Nov 2, 2023

Conversation

apple502j
Copy link
Contributor

No description provided.

@apple502j apple502j added refactor A PR that renames existing names. new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft labels Nov 2, 2023
@apple502j apple502j requested a review from Shnupbups November 2, 2023 15:45
YanisBft
YanisBft reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@YanisBft YanisBft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but it would obviously benefit of some documentation at some point

mappings/net/minecraft/server/command/ExecuteCommand.mapping Outdated Show resolved Hide resolved
@Shnupbups
Copy link
Contributor

also not a blocking comment necessarily but what is a Frame and why is its name so generic?

@apple502j apple502j requested a review from Shnupbups November 2, 2023 16:47
@apple502j
Copy link
Contributor Author

I believe a frame is an element of a call stack (which can be controlled by, you guessed it, frameControl as seen in the record).

Shnupbups
Shnupbups reviewed Nov 2, 2023
View reviewed changes
mappings/net/minecraft/server/command/ExecuteCommand.mapping Outdated
Comment on lines 265 to 266
ARG 7 flags
ARG 8 flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? that can't be right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no

@YanisBft YanisBft merged commit ad9fded into FabricMC:23w44a Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanisBft YanisBft YanisBft approved these changes

@Shnupbups Shnupbups Shnupbups approved these changes

Assignees
No one assigned
Labels
new A PR that maps mainly new names refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apple502j @Shnupbups @YanisBft