25w04a stuff I missed #4099
Merged
25w04a stuff I missed #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still a couple things left that I've not touched (for example, a datafix I don't know what to name, a functional interface I can't find what it's used for, the item subpredicate stuff for which my brain's too fried right now to make heads or tails of, etc.) but this should likely be my last PR for this snapshot :)
Shnupbups
added
refactor
mschae23
reviewed
Jan 23, 2025
| @@ -0,0 +1,12 @@ | |||
| CLASS net/minecraft/class_10719 net/minecraft/client/world/DataCache | |||
There was a problem hiding this comment.
I was hesitating on whether or not to call this one a cache, but considering that it can regenerate the stored data at any time, this is probably the right choice.
However, I think this name is way too generic for the two specific usages it has. I like the change from "world" to "context" (since the type parameter implies there could be other kinds of contexts in the future, even though it's only used with ClientWorld right now), so maybe ContextDependentDataCache?
apple502j
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a couple things left that I've not touched (for example, a datafix I don't know what to name, a functional interface I can't find what it's used for, the item subpredicate stuff for which my brain's too fried right now to make heads or tails of, etc.) but this should likely be my last PR for this snapshot :)