-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
ba30cd7
commit 8d82f8c
Showing
3 changed files
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,26 @@ | ||
6f246d4 (HEAD -> feature/impl-factory_pattern_repos, origin/feature/impl-factory_pattern_repos) feat: Replace with repo | ||
# Implementation of the Factory Pattern for repositories | ||
|
||
## Here is what I have done | ||
|
||
- Implemented the factory pattern for repositories (party_donation, party). | ||
- Implemented e2e testing routes (**/v1/partydonations**, **/plugin/partydonations**, **/plugin/parties**). | ||
- Refactored existing functions to fetch data for the routes with the repository factories. | ||
|
||
## Description | ||
|
||
I implemented the factory_pattern to handle multiple repositories. As long as unit tests, I wrote e2e tests for existing party donation-related routes. After checking the tests, I refactored the existing functions to fetch data (e.g., get_all_party_donations, get_parties) with repository factories. | ||
|
||
(Before refactoring: partydonations) | ||
e30a345 feat: Test plugin party_donation endpoint | ||
95bf7c8 feat: Test pary_donation_v1 endpoint by postgres | ||
95bf7c8 feat: Test pary_donation_v1 endpoint by postgres | ||
a5b23ea feat: Set up env for testing | ||
|
||
(After refactoring: partydonations) | ||
6f246d4 feat: Replace with repo | ||
|
||
(Before refactoring: parties) | ||
0f0c8da feat: Restructure e2e testing | ||
5450de6 feat: Test parties endpoint | ||
|
||
(After refactoring: parties) | ||
ba30cd7 feat: Replace with repo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters