Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): add politician table to scheduler #202

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

RichardKruemmel
Copy link
Member

No description provided.

@takahiromitsui
Copy link
Member

takahiromitsui commented Apr 26, 2024

After correcting the politician's data format, could you run a schedule task on your local machine to check if your changes work or not?

You'll see if it works on your logs or local database.

Just in case, I commented steps.

  1. Make sure database connection URL (refer to src/db/connection.py)
  2. Run redis (redis-server on your terminal)
  3. Run the schedule task (poetry run python -m src.entrypoints.redis_scheduled_tasks)
  4. Change schedule time on src/entrypoints/redis_scheduled_tasks.py
  5. Check logs and database on your local

This is an example.
Screenshot 2024-04-26 at 10 20 23

Copy link
Member

@takahiromitsui takahiromitsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the data format and check if it works on your local machine.

src/service_layer/utils.py Show resolved Hide resolved
src/service_layer/utils.py Show resolved Hide resolved
src/service_layer/handlers.py Show resolved Hide resolved
src/service_layer/handlers.py Show resolved Hide resolved
src/api/repository.py Show resolved Hide resolved
Copy link

@takahiromitsui takahiromitsui merged commit c0edc42 into development Apr 26, 2024
3 checks passed
@RichardKruemmel RichardKruemmel deleted the feature/add_politician_table_to_scheduler branch April 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants