Add 9-slice support for Images #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusted the methods for loading server images to support a slice parameter (which will set the Sprite.border value). sprites using a slice will not be cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slicing Serverside images
The Breakdown
this PR allows us to specify a Slice property on the
UnityEngine.UI.Imageobject to change how the image is displayed. paired with the existingimagetypefield this lets us easily create borders, corner images and glows that scale to any size with just a single assetNotes:
when setting a slice value it can only be done during instantiation, so any sprites using a slice value will not be cached. it could be reasonable to assume that a sprite will only ever be used with a single slice value (and therefore be cached), but the PR cannot make this assumption at the cost of breaking potential usecases where this isn't the case.