Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize width of the gamemodes tab and the serverlist for visual consistency #2081

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rubiksw
Copy link
Contributor

@rubiksw rubiksw commented Apr 28, 2024

This PR makes it so that the width of the gamemodes tab and the serverlist are the same for more visual consistency.

ezgif-5-0f9f7cfb4b

@rubiksw rubiksw closed this Apr 28, 2024
@rubiksw rubiksw reopened this Apr 28, 2024
@rubiksw rubiksw marked this pull request as ready for review April 28, 2024 01:43
@robotboy655
Copy link
Collaborator

The reason they are different is because the gamemodes list doesn't benefit from being stretched (it will just be a bunch of wasted space), but the server list has a few columns with varying text lengths, so the width has to be wider. This is especially an issue on lower resolutions.

@rubiksw
Copy link
Contributor Author

rubiksw commented Apr 28, 2024

This change really only affects ultra-wide resolutions where you get some funky behavior with the gamemodes title bar not lining up with the body. See below:

image

On more standard lower resolutions and it remains unchanged.

image

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants