clippy
8 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 8 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0-nightly (5ea666864 2023-06-27)
- cargo 1.72.0-nightly (03bc66b55 2023-06-23)
- clippy 0.1.72 (5ea6668 2023-06-27)
Annotations
Check warning on line 108 in ublox-short-range/src/wifi/sta.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ublox-short-range/src/wifi/sta.rs:108:73
|
108 | config_param: WifiStationConfig::WpaPskOrPassphrase(&pass),
| ^^^^^ help: change this to: `pass`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 62 in ublox-short-range/src/command/edm/urc.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ublox-short-range/src/command/edm/urc.rs:62:77
|
62 | defmt::error!("[Parse URC Start/End byte Error] {:?}", LossyStr(&resp));
| ^^^^^ help: change this to: `resp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 70 in ublox-short-range/src/command/custom_digest.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ublox-short-range/src/command/custom_digest.rs:70:51
|
70 | defmt::trace!("Digest {:?}", LossyStr(&buf));
| ^^^^ help: change this to: `buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 21 in ublox-short-range/src/command/custom_digest.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ublox-short-range/src/command/custom_digest.rs:21:47
|
21 | defmt::trace!("Digest {:?}", LossyStr(&buf));
| ^^^^ help: change this to: `buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 200 in ublox-short-range/src/client.rs
github-actions / clippy
use of `default` to create a unit struct
warning: use of `default` to create a unit struct
--> ublox-short-range/src/client.rs:200:51
|
200 | buffers.split_blocking(tx, EdmDigester::default(), atat::Config::default());
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
Check warning on line 64 in ublox-short-range/src/wifi/udp_stack.rs
github-actions / clippy
value assigned to `peer_handle` is never read
warning: value assigned to `peer_handle` is never read
--> ublox-short-range/src/wifi/udp_stack.rs:64:17
|
64 | let mut peer_handle = crate::command::PeerHandle(0);
| ^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` on by default
Check warning on line 63 in ublox-short-range/src/command/wifi/mod.rs
github-actions / clippy
unused variable: `e`
warning: unused variable: `e`
--> ublox-short-range/src/command/wifi/mod.rs:63:73
|
63 | atat::serde_at::from_slice::<NoResponse>(resp).map_err(|e| atat::Error::Parse)
| ^ help: if this is intentional, prefix it with an underscore: `_e`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 224 in ublox-short-range/src/wifi/tcp_stack.rs
github-actions / clippy
unneeded unit expression
warning: unneeded unit expression
--> ublox-short-range/src/wifi/tcp_stack.rs:224:33
|
224 | ... ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default