Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and add Nix flake #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

willcohen
Copy link
Contributor

I'm working on dusting off my branch for #69, so in advance of that, I thought it might be worth tidying up the aging dependency list on the main branch first!

@willcohen
Copy link
Contributor Author

This also should close #74, though not till it's incorporated into a release

Copy link

@isaacbrodsky isaacbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h3-java update looks good to me

@willcohen
Copy link
Contributor Author

In addition, I just added a little more housekeeping, to try to prepare for adding CI back in (using GH actions, maybe? The cljs branch definitely will need it, since there's more targets to check!). I added a basic Nix configuration so there's a reproducible environment that can be generated, and I added clj-build with a goal of starting to move builds toward deps.edn, now that Clojure's got tools.build.

@willcohen willcohen changed the title Update dependencies Update dependencies and add Nix flake Jan 6, 2022
@worace
Copy link
Contributor

worace commented Jan 6, 2022

@willcohen great to see you are messing around with this again! I am afraid I haven't touched it in a while.

RE:

to prepare for adding CI back in (using GH actions, maybe?)

Can you remind me where we left off on that? I guess we took the old CI off because travis shut down and we never got a new one set up?

@willcohen
Copy link
Contributor Author

I don't think we ever discussed it! I think what you said is exactly the current state of it. GitHub Actions seems like they work fine for lots of other projects. The main blocker for me and the clojurescript branch is the fact that I have to rewrite the entire test suite since midje isn't cross compatible, so it's a good chance to rethink through CI since the test suite could see a big change soon too. tools.build seems like a pretty solid official-ish successor to lots of the things that geo still depends on lein for, so if it's okay I might try to think through a CI process that lines up with clj/tools.build/clojure.test and perhaps GH actions, and we can kick the tires on some options once I get that a little further along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants