Enable auditing for package vulnerabilities #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it more difficult to ship a Faithlife.Build package that has transitive dependencies on vulnerable packages, which improves the experience for consumers. The changes to Build.csproj are temporary until an updated package can be published.
bgrainger
commented
Jul 11, 2024
| @@ -72,7 +72,7 @@ public sealed class DotNetClassicTool | |||
|
|
|||
| var bestMatch = VersionRange.Parse(packageVersion).FindBestMatch(packageDirectories) ?? | |||
| throw new BuildException($"Found restored NuGet package folder but no version is a best match: {packageFullPath}"); | |||
| var packageBestMatchPath = Path.Combine(packagesPath, packageName.ToLowerInvariant(), bestMatch.OriginalVersion); | |||
| var packageBestMatchPath = Path.Combine(packagesPath, packageName.ToLowerInvariant(), bestMatch.OriginalVersion ?? bestMatch.ToString()); | |||
There was a problem hiding this comment.
This was changed due to a nullability analysis warning. Not sure if ! would have worked OK here (i.e., if OriginalVersion is guaranteed to be non-null with the way we initialize it).
ejball
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it more difficult to ship a Faithlife.Build package that has transitive dependencies on vulnerable packages, which improves the experience for consumers.
The changes to Build.csproj are temporary until an updated package can be published.