Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Declare strict types in examples #777

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix: Declare strict types in examples #777

merged 1 commit into from
Sep 21, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 21, 2023 •
edited
Loading

What is the reason for this PR?

  • declares strict types in examples in README.md

Somewhat related to #742.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@localheinz localheinz added the bug Something isn't working label Sep 21, 2023
@pimjansen pimjansen merged commit 25a8f13 into FakerPHP:2.0 Sep 21, 2023
12 checks passed
@localheinz localheinz deleted the fix/declare branch September 21, 2023 13:59
@localheinz
Copy link
Member Author

Thank you, @pimjansen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

@bram-pkg bram-pkg Awaiting requested review from bram-pkg

Assignees

@pimjansen pimjansen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @pimjansen