Improve address provider for en_NG locale #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Postcodes in Nigeria are strictly made up of 6 digits. The `$postcode` variable has been updated to reflect that. - Replaced 'county' with 'state' - which is the actual term used to refer to the major sub-administrative governments directly below the Federal. - City names in Nigeria do not require a suffix. Hence, the array has been left empty. - It's common to see street names in Nigeria with prefixes such as 'Chief', 'General', 'Rev.', 'Bishop'. The street name format has been updated to reflect this. - 'Region' in Nigeria typically refers to the political regional divisions of the country, and not cities. Hence, `cityName` has been added (instead) to reflect actual city names, and `region` has been updated to reflect the political regional divisions of Nigeria.
bram-pkg
approved these changes
Nov 8, 2023
|
Seems there are backwards compatible breaking changes, could you look at those? |
|
Just some PHPStan errors left now, seems you can remove those from the baseline |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
To improve the address data generated for the en_NG locale.
Author's checklist
Summary of changes
$postcodevariable has been updated to reflect that.cityNamehas been added (instead) to reflect actual city names, andregionhas been updated to reflect the political regional divisions of Nigeria.Review checklist
CHANGELOG.md