Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gmail.com.au from free email domains. #885

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from

Conversation

da-mask
Copy link

@da-mask da-mask commented May 23, 2024

What is the reason for this PR?

freeEmail() function for AU provider included the domain gmail.com.au, which does not exist. It causes failing tests when validating emails with email:rfc,dns

Author's checklist

Summary of changes

Removed the errant domain from the en_AU/Internet provider file

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@da-mask da-mask marked this pull request as ready for review May 23, 2024 00:58
@pimjansen
Copy link

Im not sure im a fan of this @bram-pkg since Faker only creates "valid structure" but never valid content. In fact the email address is valid. I think the problem is that a lookup is done on the domain. In fact i think most providers have the same problem in this case since . probably also does not exist

@bram-pkg
Copy link
Member

We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?

@pimjansen
Copy link

We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?

Well it is valid but non existing. There is nothing wrong with the domain itself

@da-mask
Copy link
Author

da-mask commented May 24, 2024

I think free emails should return actual free emails, not non existent ones.

@bram-pkg
Copy link
Member

I must agree with @da-mask here. It should return known good email domains to register on for free.

@da-mask
Copy link
Author

da-mask commented May 25, 2024

I'm not sure if you require further action from me?

@bram-pkg
Copy link
Member

@pimjansen I don't know what's going on with BC Roave, do you know how to fix?

@pimjansen
Copy link

@pimjansen I don't know what's going on with BC Roave, do you know how to fix?

We need to allow them with regex. Those in Core are acceptable since there is a non BC promise but those provider issues are bad though.

@da-mask
Copy link
Author

da-mask commented Aug 4, 2024

Is there anything I can do to move this along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gmail.com.au domain causes email validation to fail
3 participants