Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ancient cyphers #838

Merged
merged 11 commits into from
Feb 3, 2025
Merged

Conversation

Robotgiggle
Copy link
Contributor

@Robotgiggle Robotgiggle commented Jan 23, 2025

Adds ancient cyphers, as seen in #818. Implements #432.

  • Ancient cyphers generate in loot chests, and come preset with a simple hex
  • They look like normal cyphers but with tarnished copper and slightly faded amethyst, and work identically
  • Unlike normal cyphers, they display their stored hex in the tooltip, so they can serve as a tutorial for new players
  • You can also erase them and put in your own spells using Craft Cypher
  • Configurable injection list and injection chance for ancient cyphers, just like how it works for lore fragments

This was referenced Jan 23, 2025
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the config system here could use some work, ideally have it be datapackable and not stuffed all into a List. Arguably that could be done later? But I'd rather not have it be a breaking change later with dropping support for this config system.

Otherwise just small changes.

@SamsTheNerd
Copy link
Member

Actually, if we wanna just leave it non configurable and have it be hard-coded for now then we could figure out the datapack support in the future without locking us into this? I'd like to get more datapack infrastructure set up based around Codecs at some point in the future.

Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. left some small nitpicks. Otherwise fine to merge

@SamsTheNerd SamsTheNerd merged commit 1d3a855 into FallingColors:main Feb 3, 2025
4 checks passed
@Robotgiggle Robotgiggle deleted the ancient-cyphers branch February 3, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants