-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAC with PERIODS #552
Draft
mother10
wants to merge
13
commits into
FamilySearch:splac-beside-plac
Choose a base branch
from
mother10:mother10-Splac
base: splac-beside-plac
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,066
−23
Draft
SPLAC with PERIODS #552
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5e0d387
Update gedcom-3-structures-1-organization.md
mother10 dbbaa6a
Examples for SPLAC addition
mother10 f1f4481
Update gedcom-2-data-types.md
mother10 ad232dd
Update gedcom-3-structures-1-organization.md
mother10 0b887ff
Update gedcom-3-structures-3-meaning.md
mother10 217067b
Update gedcom-3-structures-4-enumerations.md
mother10 4bd0e55
Delete specification/terms/gedcom-6-appendix-examples.md
mother10 af1f507
Create gedcom-6-appendix-examples.md
mother10 944f1cb
Update gedcom-3-structures-1-organization.md
mother10 b856acf
Update gedcom-3-structures-1-organization.md
mother10 7189c80
Update gedcom-3-structures-1-organization.md
mother10 a39dd80
Error in examples for some SPLACs
mother10 190beea
Update gedcom-3-structures-1-organization.md
mother10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "Float" would be a better name for this proposed type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dave, first thanks for the comments!
About Float, yes, I thought about that. But here this type is only meant to hold the lenght/distance, not the result of a very complicated calculation, so thats why I took Decimal. Should I change that into Float?