Update Carmen and fix Dependencies #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejmode
approved these changes
Oct 27, 2023
HerbertJordan
force-pushed
the
herbert/update_carmen
branch
from
ededaa0 to
05d5137
Compare
HerbertJordan
force-pushed
the
herbert/update_carmen
branch
from
05d5137 to
4668c38
Compare
matejmode
pushed a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Carmen dependency and updates Aida code to match Carmen interface changes. In particular, the way invalid configurations are reported has been updated lately, causing compatibility issues.
While doing so, also Aida's state test infrastructure was updated to cover all configuration options offered by Carmen.
Type of change
TODO: