Fix manual generation #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabrador
approved these changes
Nov 8, 2023
| @@ -157,7 +157,7 @@ func GenDeletedAccountsAction(cfg *utils.Config, ddb *substate.DestroyedAccountD | |||
|
|
|||
| for iter.Next() { | |||
| tx := iter.Value() | |||
| if tx.Block > cfg.Last { | |||
| if tx.Block > lastBlock { | |||
There was a problem hiding this comment.
most of the time the last block is excluded, is this what we need here?
There was a problem hiding this comment.
cfg.Last is not set because the command doesn't intake range from arguments. Therefore lastBlock is supplied explicitly from g.opera.lastBLock
Fix generate arguments error message Co-authored-by: Petr Hanzl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual generation needed to be rewritten to generate not from events, but from existing aida-db. This tool is designed only for fixing autogen generation in case the generation got corrupted.
Type of change