Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether temp directory exists in config #798

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

wsodsong
Copy link
Collaborator

@wsodsong wsodsong commented Nov 7, 2023

Description

The default temp directory is changed to system default. This change introduce a utility function directoryExists which return true if a given path exists. This utility function checks existence of aida-db and db temp directory. In the case, db temp directory doesn't exist, program terminates.

Fixes #734 , #600

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@wsodsong wsodsong force-pushed the wasuwee/fix-default-tmp-dir branch from be4e666 to 0e4f5a5 Compare November 8, 2023 10:07
Copy link
Collaborator

@cabrador cabrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very much needed feature!

utils/config.go Show resolved Hide resolved
utils/config.go Show resolved Hide resolved
Copy link
Collaborator

@matejmode matejmode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@wsodsong wsodsong force-pushed the wasuwee/fix-default-tmp-dir branch 2 times, most recently from 5c6ef38 to 1624a73 Compare November 10, 2023 08:34
The default temp directory is changed to system default. This change
introduces a utility function `directoryExists` which return true if a
given path exists. This utility function checks existance of aida-db and
db temp directory. In the case, db temp directory doesn't exist, system
default temporary directory is used instead.
@wsodsong wsodsong force-pushed the wasuwee/fix-default-tmp-dir branch from 1624a73 to d1b8dec Compare November 13, 2023 02:57
@wsodsong wsodsong merged commit 8a187a3 into develop Nov 13, 2023
1 check passed
@wsodsong wsodsong deleted the wasuwee/fix-default-tmp-dir branch November 22, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants