Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins notifications only for develop branch #898

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

Lubomir-Jahn
Copy link
Collaborator

Description

Fixes the behavior where jenkins should notify only about develop branch

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@Lubomir-Jahn Lubomir-Jahn changed the base branch from main to develop December 7, 2023 15:13
Copy link
Collaborator

@matejmode matejmode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about the logic first. In #895 there is option to notify just an owner. By handling him as a commit author. The develop logic is correct, but there should be else branch for other commits to have their statuses written in direct messages. If not we should think this over.

@Lubomir-Jahn
Copy link
Collaborator Author

That's actually good point, I've been just caught in the problem that PR jobs still gets notifications despite my last changes and I wanted to fix that. Thanks for pointing that out but there is no means to tag commit user optionaly. We either always tag an owner or never. If I understand that correctly, there is now way to let the jenkinsfile pipeline know that owner do or does not want to get notification, right? Or am I missing something?

@cabrador cabrador changed the title Jenkins notofications only for develop branch Jenkins notifications only for develop branch Dec 8, 2023
@wsodsong
Copy link
Collaborator

@Lubomir-Jahn is this PR ready for review?

@Lubomir-Jahn
Copy link
Collaborator Author

Yes it is.

@Lubomir-Jahn Lubomir-Jahn merged commit cb37d23 into develop Dec 14, 2023
1 check passed
@wsodsong wsodsong deleted the lubo/fix-jenkins-notofications branch April 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants