-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins notifications only for develop branch #898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about the logic first. In #895 there is option to notify just an owner. By handling him as a commit author. The develop logic is correct, but there should be else branch for other commits to have their statuses written in direct messages. If not we should think this over.
That's actually good point, I've been just caught in the problem that PR jobs still gets notifications despite my last changes and I wanted to fix that. Thanks for pointing that out but there is no means to tag commit user optionaly. We either always tag an owner or never. If I understand that correctly, there is now way to let the jenkinsfile pipeline know that owner do or does not want to get notification, right? Or am I missing something? |
@Lubomir-Jahn is this PR ready for review? |
Yes it is. |
Description
Fixes the behavior where jenkins should notify only about develop branch
Type of change
Please delete options that are not relevant.