Refactor burn native tokens method #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
previously approved these changes
Dec 16, 2024
# Conflicts: # contracts/sfc/SFC.sol
gpersoon
reviewed
Dec 17, 2024
gpersoon
reviewed
Dec 17, 2024
contracts/sfc/SFC.sol
Outdated
| function _burnFTM(uint256 amount) internal { | ||
| if (amount != 0) { | ||
| function _burnNativeTokens(uint256 amount) internal { | ||
| if (amount != 0 && totalSupply >= amount) { |
There was a problem hiding this comment.
if amount > totalSupply you could also do amount = totalSupply; and then burn that amount
There was a problem hiding this comment.
replaced with revert
gpersoon
reviewed
Dec 17, 2024
| payable(address(0)).transfer(amount); | ||
| emit BurntFTM(amount); | ||
| emit BurntNativeTokens(amount); |
There was a problem hiding this comment.
you could also use call instead of transfer
There was a problem hiding this comment.
this is pending in #111
thaarok
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.