Use system CMake if available #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of depending on `cmake` and `ninja` executables unconditionally, add these dependencies only if system executables are not available. This ensures that system CMake is used when available (instead of being overridden by the PyPI build of CMake), so the user can benefit from improved portability due to downstream patching and avoids unnecessary dependencies. This also adjusts the generator choice to support system `ninja` install, i.e. one without a `ninja` module.
|
Thanks for the PR @mgorny Any ideas? |
|
Hmm, that's an interesting problem. FWICS that implies that no entry points installed via |
pseudo-rnd-thoughts
approved these changes
Feb 8, 2025
pseudo-rnd-thoughts
merged commit e57455a
into
Farama-Foundation:master
28 checks passed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on
cmakeandninjaexecutables unconditionally, add these dependencies only if system executables are not available. This ensures that system CMake is used when available (instead of being overridden by the PyPI build of CMake), so the user can benefit from improved portability due to downstream patching and avoids unnecessary dependencies.This also adjusts the generator choice to support system
ninjainstall, i.e. one without aninjamodule.