-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix definition of "intersection-multi-agent-v1" with MultiAgentWrapper #609
Fix definition of "intersection-multi-agent-v1" with MultiAgentWrapper #609
Conversation
Can this be merged asp @eleurent @jjshoots ? We need this for MO-Gymnasium Farama-Foundation/MO-Gymnasium#95 |
Shouldn't you try to bump Gymnasium to 1.0 in this PR? |
It is not necessary on MO-Gymnasium side. |
I think this issue is resolved on Gymnasium main, could you test locally to confirm? |
I got the same error using the last Gymnasium state on Github:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, dont worry then
@pseudo-rnd-thoughts I guess it makes sense to make a new release for highway-env? The last one is from more than one year ago. |
Yes, that is probably a good idea |
Thanks for this fix! Made a new release: v1.9.1 |
This PR changes the register of "intersection-multi-agent-v1" to apply the
MultiAgentWrapper
on the register method.The previous version is giving an error when importing highway-env with gymnasium 1.0 since
MultiAgentWrapper(MultiAgentIntersectionEnv)
is applying a wrapper to a class instead of an object.