Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super in LinearVehicle.randomize_behavior #614

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Call super in LinearVehicle.randomize_behavior #614

wants to merge 1 commit into from

Conversation

m-walters
Copy link
Contributor

The super method updates the IDMVehicle.DELTA value, for what it's worth

@pseudo-rnd-thoughts
Copy link
Member

Could you explain the expected behaviour and the actual behaviour currently?
Also, could you produce a test for this behaviour?

@m-walters
Copy link
Contributor Author

it just seemed logical to propagate up the randomize_behavior call. It is actually inconsequential atm though, since this updates theIDMVehicle.DELTA attribute, but that attribute is only used in IDMVehicle.accelerate, which has no calls in child class LinearVehicle, since it uses its own accelerate method.
You can close if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-walters @pseudo-rnd-thoughts