Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CleanRL mutli-agent Atari example #1033

Merged
merged 8 commits into from
Jul 20, 2023

Conversation

elliottower
Copy link
Member

Description

I updated this code in vwxyzjn/cleanrl#408 but I think it'd be good to mirror the code onto here so PettingZoo users see there's a full script with WandB and TensorBoard integration set up already. Changed the number of timesteps to be smaller by default because our CI doesn't take command line args for running tutorials, but other than that it's the same. Looked into embedding an external file using sphinx literalinclude but it seems not to be possible to do it from another separate repo that doesn't use sphinx.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower marked this pull request as ready for review July 18, 2023 22:18
@elliottower elliottower merged commit 6a20a32 into Farama-Foundation:master Jul 20, 2023
33 checks passed
@elliottower elliottower deleted the cleanrl-atari branch July 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant