Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: async support on message type and schema registry resolvers #430

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat!: async support on message type and schema registry resolvers #430

merged 1 commit into from
Sep 25, 2023

Conversation

jose-sousa-8
Copy link
Contributor

@jose-sousa-8 jose-sousa-8 commented Sep 12, 2023 •
edited
Loading

Description

  • Adds async support for both Consume and Produce message type resolver.
  • Adds async support for the Resolve method in the schema registry type resolver.

Fixes #302 #305

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

@filipeesch filipeesch marked this pull request as ready for review September 15, 2023 09:32
@jose-sousa-8 jose-sousa-8 force-pushed the feat/async-support-messagetyperesolver branch from 3a10389 to da43538 Compare September 15, 2023 09:35
@jose-sousa-8 jose-sousa-8 force-pushed the feat/async-support-messagetyperesolver branch from da43538 to e744fea Compare September 15, 2023 09:49
brmagadutra
brmagadutra approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@brmagadutra brmagadutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

erik-catalao
erik-catalao approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@erik-catalao erik-catalao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelfoliveira joelfoliveira merged commit 0057d79 into Farfetch:release/3.0 Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-catalao erik-catalao erik-catalao approved these changes

@JoaoRodriguesGithub JoaoRodriguesGithub JoaoRodriguesGithub approved these changes

@brmagadutra brmagadutra brmagadutra approved these changes

@filipeesch filipeesch filipeesch approved these changes

@joelfoliveira joelfoliveira joelfoliveira approved these changes

@simaoribeiro simaoribeiro Awaiting requested review from simaoribeiro

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jose-sousa-8 @joelfoliveira @filipeesch @brmagadutra @JoaoRodriguesGithub @erik-catalao