feat: allow use of cluster defined values for topic creation #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikofps
approved these changes
Apr 11, 2024
ruiqbarbosa
approved these changes
Apr 11, 2024
fasazevedo
approved these changes
Apr 11, 2024
brmagadutra
approved these changes
Apr 11, 2024
ailtonguitar
approved these changes
Apr 12, 2024
joelfoliveira
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If passing
-1forNumPartitionsorReplicationFactorwhen creating topics, the creation will use the cluster-default values for these values. This change allows for defaulting to using cluster values, and over-riding them if required. This reduces a lot of boilerplate code when setting up a cluster in code.How Has This Been Tested?
Added integration tests to test this against a Kafka instance.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement