Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance pattern piece dock #1046

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

DSCaskey
Copy link
Contributor

This feature enhances the Pattern Pieces dock.

  • Adds a Pattern Piece Letter column.
  • Adds a toolbar with the following tool buttons
  • Include All pieces
  • Invert included pieces
  • Exclude All pieces
  • Lock All pieces
  • Invert locked pieces
  • Unlock All pieces
  • Color selector
  • Edit piece properties
  • Replaces the checkmark icon with the "eye" visible on / off icon.
  • Fixes the Sort by Color

piecedock

Fixes issue #1000

@DSCaskey DSCaskey requested a review from csett86 November 26, 2023 10:01
@DSCaskey DSCaskey self-assigned this Nov 26, 2023
@DSCaskey DSCaskey linked an issue Nov 26, 2023 that may be closed by this pull request
@DSCaskey DSCaskey changed the title feat: ehance pattern piece dock feat: enhance pattern piece dock Nov 26, 2023
@ghost
Copy link

ghost commented Nov 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

what-the-diff bot commented Nov 26, 2023

PR Summary 📝

🌐 This pull request makes terrific strides in language accessibility, making the product much more global-friendly. It's been all about extending language support and localizing the user interface to help our users around the world feel at home when using our product. 🌍

  • Expanded Language support 🗣️

    Hooray to our multilingual team, we now have updated translations for:

    • Czech (cs_CZ) 🇨🇿
    • German (de_DE) 🇩🇪
    • Greek (el_GR) 🇬🇷
    • Canadian English (en_CA) 🇨🇦
    • British English (en_GB) 🇬🇧
    • Indian English (en_IN) 🇮🇳
    • American English (en_US) 🇺🇸

    and so many more languages, for terms such as "Select Color", "Edit pattern piece properties", "Included", "Pattern piece is locked", among others. 🎉

  • Enhancements to the interface geometry in pieces_widget.ui 📐

    We tweaked the interface to look more neat and user friendly. There were modifications to the width and height properties. A new minimumSize property was also added to make sure things look just right. 🖥️

  • New Buttons in the Interface 🖱️

    We have now included several QToolButton widgets to the layout, making it more engaging and adding more functionalities. 👌

  • Updated tableWidget for better organization 📊

    This pull request updates the tableWidget; we increased the column count and modified how the data is displayed to create a more streamlined and intuitive view. We also changed the layout for enhanced appearance. 🌟

  • Improved Code in pieces_widget.h 🛠️

    Adjustments were made to the pieces_widget.h file. We added new functions and updated existing ones to take advantage of the new constructor parameter.

  • Include new icon in icon.qrc 🖼️

    A new icon has been added to our resources. Welcome, invert_selection.png! 🎉

Hold on tight for an even more collaborative and engaging experience! Onwards and upwards, team! 🚀💙

@DSCaskey DSCaskey requested review from slspencer and removed request for csett86 November 27, 2023 08:29
@slspencer slspencer merged commit 89a876e into develop Nov 28, 2023
9 checks passed
@slspencer slspencer deleted the enhance-pattern-piece-dock branch November 28, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: sorting by color does not work in the pieces dock
2 participants