Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old conditionals have been removed to solve compilation issue #1091

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Onetchou
Copy link
Contributor

No description provided.

@Onetchou Onetchou requested a review from DSCaskey April 15, 2024 17:47
@Onetchou Onetchou self-assigned this Apr 15, 2024
Copy link

what-the-diff bot commented Apr 15, 2024

Magnificent Work on the PR! 🎉

In this pull request, we have some important changes to the application that will improve things and make our lives much better.

  • Beautiful Removal of GistFileName Constant 🗑️
    The GistFileName constant that was once part of our Application2D class is no longer with us. By leaving out this particular item, we've made our code more trim, fit and healthy. Our application is positive on this change and says a cheery goodbye to extra luggage. 💼👋

  • Revamp of startLogging Method 🔄
    The startLogging method has developed a new philosophy towards life. It's decided to stop calling the ClearOldReports function, especially while running on Windows with a GNU compiler. This change means less unnecessary activity and a smoother, more efficient logging process. A great step-up for our application's performance on Windows. 💻🚀

Fabulous job, team! Your hard work and dedication really shine through these changes. Onwards and upwards, to the next great thing! 💪🌟

@DSCaskey DSCaskey merged commit e829b84 into develop Apr 15, 2024
10 checks passed
@DSCaskey DSCaskey deleted the reporting-compilation-issue branch April 15, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants