Skip to content

Commit

Permalink
Fix #123: make JAXB-annotations module dependency "optional" (#203)
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder authored Dec 6, 2024
1 parent c312157 commit 9f5c064
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cbor/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@
<artifactId>jackson-dataformat-cbor</artifactId>
</dependency>
<!-- may also need JAXB annotation support -->
<!-- 05-Dec-2024, tatu: [jaxrs-providers#123] Make optional -->
<dependency>
<groupId>tools.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<optional>true</optional>
</dependency>
</dependencies>
<build>
Expand Down
2 changes: 2 additions & 0 deletions json/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@
<version>${project.version}</version>
</dependency>
<!-- also need JAXB annotation support -->
<!-- 05-Dec-2024, tatu: [jaxrs-providers#123] Make optional -->
<dependency>
<groupId>tools.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<optional>true</optional>
</dependency>

<!-- test deps should mostly come from parent, including jersey,
Expand Down
3 changes: 3 additions & 0 deletions release-notes/VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Sub-modules:

3.0.0 (not yet released)

#123: Change `jackson-module-jaxb-annotations` dependency to `optional`
in `pom.xml`s
(requested by @gopackgo90)
- Minimum Java baseline: Java 17
- Remove `Annotations` enum abstraction, replace with direct `AnnotationIntrospector`
configuration.
2 changes: 2 additions & 0 deletions smile/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@
<artifactId>jackson-dataformat-smile</artifactId>
</dependency>
<!-- may also need JAXB annotation support -->
<!-- 05-Dec-2024, tatu: [jaxrs-providers#123] Make optional -->
<dependency>
<groupId>tools.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<optional>true</optional>
</dependency>
</dependencies>
<build>
Expand Down
2 changes: 2 additions & 0 deletions xml/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@
<artifactId>jackson-dataformat-xml</artifactId>
</dependency>
<!-- may also need JAXB annotation support -->
<!-- 05-Dec-2024, tatu: [jaxrs-providers#123] Make optional -->
<dependency>
<groupId>tools.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<optional>true</optional>
</dependency>
<!-- But Stax2 API must be included -->
<dependency>
Expand Down
2 changes: 2 additions & 0 deletions yaml/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ using standard Jackson data binding.
<artifactId>jackson-dataformat-yaml</artifactId>
</dependency>
<!-- may also need JAXB annotation support -->
<!-- 05-Dec-2024, tatu: [jaxrs-providers#123] Make optional -->
<dependency>
<groupId>tools.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<optional>true</optional>
</dependency>

<!-- Use JSON and Smile providers for testing that content negotiation works with multiple providers registered. -->
Expand Down

0 comments on commit 9f5c064

Please sign in to comment.