Accept file path or file object #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielaRiesgo
force-pushed
the
accept-files
branch
3 times, most recently
from
7d13eeb to
3cd2dab
Compare
danielaRiesgo
force-pushed
the
accept-files
branch
from
3cd2dab to
8cb0438
Compare
|
Why not just send the content directly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello there! Thanks for the library.
I was looking for something like proposed here.
But a non-breaking change was required, so I'm thinking this is a good option. It's what I've seen in other frameworks of this sort.