Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Opencv Crash Region out of bounds #1958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArthurKun21
Copy link
Collaborator

@ArthurKun21 ArthurKun21 commented Jan 31, 2025

Opencv Crash Region out of bounds

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

For some odd reason, I encountered a problem wherein when checking support's skills and it was out of frame(only the servant image was visible and it matched with the template) it would led to crash. Changing the mat to null-able resolves this issue.

Screenshots

Testing

  1. Ensure the battle config has a servant selected and skills enabled.
  2. Go to the support screen.
  3. Find the servant and when found, scroll the screen and ensure that the servant is visible but not the skills.
  4. Run the script
  5. ....
  6. Crash!

Additional context

This is edge case but damn

@ArthurKun21 ArthurKun21 changed the title Opencv Crash Region out of bounds Fix Opencv Crash Region out of bounds Jan 31, 2025
Copy link

Build 116

Download the latest APK for testing here

Note

You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

@ArthurKun21 ArthurKun21 requested a review from reconman January 31, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant