Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexleung/dev branch #1712

Merged
merged 128 commits into from
Dec 7, 2023
Merged

Alexleung/dev branch #1712

merged 128 commits into from
Dec 7, 2023

Conversation

fedml-alex
Copy link
Collaborator

No description provided.

fedml-alex and others added 30 commits November 6, 2023 22:38
Copy link

gitguardian bot commented Dec 7, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4672198 Generic High Entropy Secret 66a1b29 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/custom_data_and_model/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret 66a1b29 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/one_line/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret 66a1b29 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/step_by_step/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret ddd0dc3 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/one_line/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret ddd0dc3 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/custom_data_and_model/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret ddd0dc3 python/examples/federate/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/step_by_step/config/fedml_config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@fedml-alex fedml-alex closed this Dec 7, 2023
@fedml-alex fedml-alex reopened this Dec 7, 2023
@fedml-alex fedml-alex merged commit 00b1266 into dev/v0.7.0 Dec 7, 2023
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant