-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: exercises class 6 #57
Open
carl32crc
wants to merge
2
commits into
master
Choose a base branch
from
ejercicios-clase-6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
const heroes = ['batman', 'superman', 'wonderwoman', 'aquaman']; | ||
|
||
const handler = { | ||
set: (object, property, value) => { | ||
if (typeof value === 'string' && value.toLowerCase() === 'aquaman') { | ||
throw Error('Aquaman ya existe') | ||
} | ||
return Reflect.set(object, property, value) | ||
} | ||
} | ||
|
||
const heroesProxy = new Proxy(heroes, handler) | ||
heroesProxy.push('ramdomheroe') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/** | ||
* Nuestro carrito de la compra es bastante inteligente, pero no estaría | ||
* mal que lo fuese aún más. Crear un metodo anade que reciba un | ||
* producto y lo añada al carrito. Para ello Hay que tener en cuenta las siguientes cuestiones: | ||
|
||
- Si un producto ya existe en el carrito hay que aumentar la cantidad, no duplicarlo. | ||
- Si el precio del nuevo producto es menor, será este el que predomine. | ||
- La cantidad por defecto será 1, pero si hubiera más habrá que sumarlos. | ||
- Hay que validar los tipos, el nombre del producto es un string, | ||
la cantidad es un entero y el precio es un número. En caso de que | ||
se introduzca un producto con un tipo inválido se debe lanzar una excepción. | ||
*/ | ||
|
||
class Product { | ||
amount = 1 | ||
name = '' | ||
price = 0 | ||
|
||
incrementAmount() { | ||
++this.amount | ||
} | ||
|
||
newPrice(price) { | ||
if (price < this.price) this.price = price | ||
} | ||
} | ||
|
||
const handler = { | ||
set: (object, property, value) => { | ||
if (typeof value !== 'number' && property === 'price') { | ||
throw Error(`Number nedeed in property:${property}`) | ||
} | ||
|
||
if (typeof value !== 'string' && property === 'name') { | ||
throw Error(`String nedeed in property:${property}`) | ||
} | ||
|
||
if (!Number.isInteger(value) && property === 'amount') { | ||
throw Error(`Integer nedeed in property:${property}`) | ||
} | ||
return Reflect.set(object, property, value) | ||
} | ||
} | ||
|
||
const shoppingCar = [] | ||
|
||
function setProductInShoppingCar(myProduct) { | ||
const productInShoppingCar = shoppingCar.find(product => product.name === myProduct.name) | ||
if (productInShoppingCar) { | ||
productInShoppingCar.incrementAmount() | ||
productInShoppingCar.newPrice(myProduct.price) | ||
} else { | ||
const productProxy = new Proxy(new Product(), handler) | ||
productProxy.name = myProduct.name | ||
productProxy.price = myProduct.price | ||
shoppingCar.push(productProxy) | ||
} | ||
} | ||
|
||
|
||
setProductInShoppingCar({ name: 1, price: 19 }) // -> show error message "String nedeed in property:name" | ||
setProductInShoppingCar({ name: 'randomproduct', price: 'qwe' }) // -> show error message "Number nedeed in property:price" | ||
setProductInShoppingCar({ name: 'cookies', price: 19 }) | ||
setProductInShoppingCar({ name: 'cookies', price: 12 }) | ||
setProductInShoppingCar({ name: 'watermelon', price: 2 }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me mola mucho tu solución, sólo una cosa, podrías basarte en el carrito que hemos usado en otros ejercicios y delegar todas las comprobaciones en el proxy? con eso ya te lo tendrías perfecto 👏