Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock ocean current calculation function #213

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

woensug-choi
Copy link
Collaborator

I think it's that TransientCurrentPlugin::UpdateDatabase is modifying the database (EDIT: and other vectors) in one thread while TransientCurrentPlugin::CalculateOceanCurrent is reading it another.

Field-Robotics-Lab/glider_hybrid_whoi#64

This PR tries to lock and unlock the function.

@woensug-choi woensug-choi added the bug Something isn't working label Feb 21, 2022
@daewok
Copy link
Contributor

daewok commented Feb 21, 2022

TransientCurrentPlugin::UpdateDatabase needs to be locked as well.

@woensug-choi
Copy link
Collaborator Author

Leaving a note of your test results,

Then I locked TransientCurrentPlugin::UpdateDatabase as well. It's been running for 6 hours (sim time)/11 minutes (real time) now without an issue.

And about the branch organization,

Most of what we nees would be in #180. It would not include intlatlon, gpaviewer and stuff. So I am trying to keep the bathymetry_plugin_whoi branch at my fork.
the branch will not be in upatream dave and will not be merges into master. Dave team has decided not to include bathymetry files in the repo but make it downloadable reading the tutorial. The download file includes both bathymery examples(not buzzbay) and initlatlon/gps viewer.
The branch at my fork will include Buzzbay and some puerto rico and minor adjustings for epic-daug if needed.
In Field-Robotics-Lab/glider_hybrid_whoi#66, the pre-release I was hoping to get it tested and merged after usjng the simulator as it ia for the puertorico, the target repo is changed from Field-Robotics-Lab/dave to woensugchoi/dave

@woensug-choi woensug-choi merged commit 61d7801 into master Feb 23, 2022
@woensug-choi woensug-choi deleted the lock_stratified_current_update branch February 23, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants