Make useSearch isomorphic #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CharlyMartin
changed the title
CharlyMartin
dismissed
barbaraperic’s stale review
The base branch was changed.
CharlyMartin
force-pushed
the
UXIT-2020/isomorphic-search-hook
branch
from
67cc96b to
ab52df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is PR 2/3 to make our hooks isomorphic, meaning they don't contain any server or client-specific code and can run in both environments. More information on the motivation is in the Notion ticket.
📝 Description
This PR is about making
useSearchisomorphic.🛠️ Key Changes
NextServerSearchParamsfromuseSearchprops and usesearchQueryinstead🧪 How to Test
Make sure the search works the same as on fil.org