Add grouped category listbox for ecosystem project form #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CharlyMartin
force-pushed
the
UXIT-1925/redesign-category-listbox-bis
branch
from
c6993dd to
d3eb3a9
Compare
CharlyMartin
force-pushed
the
UXIT-1925/redesign-category-listbox-bis
branch
from
d3eb3a9 to
0310909
Compare
CharlyMartin
force-pushed
the
UXIT-1925/redesign-category-listbox-bis
branch
from
0310909 to
b6bbc13
Compare
CharlyMartin
changed the title
CharlyMartin
requested review from
mirhamasala
and removed request for
mirhamasala
2 tasks
mirhamasala
reviewed
Feb 7, 2025
| children: React.ReactNode | ||
| } | ||
|
|
||
| export function ListboxOptionGroup({ |
There was a problem hiding this comment.
Would ListboxGroupHeader describe this component better?
Suggested change
| export function ListboxOptionGroup({ | |
| export function ListboxGroupHeader({ |
mirhamasala
reviewed
Feb 7, 2025
| @@ -14,19 +15,24 @@ export type OptionType = { | |||
|
|
|||
| type ListboxOptionProps<Value extends OptionType> = { | |||
| option: Value | |||
| grouped?: boolean | |||
There was a problem hiding this comment.
Instead of passing a prop, which makes the child component dependent on the parent’s state, what about applying the following style directly to ListboxOptionGroup:
<span className="block pl-1">
{children}
</span>This approach improves encapsulation by keeping the spacing logic within ListboxOptionGroup, ensuring that ListboxOption components remain unaware of their surrounding context. It also maintains a clearer separation of concerns.
mirhamasala
requested changes
Feb 7, 2025
There was a problem hiding this comment.
@CharlyMartin - Looking good - Left a naming suggestion and encapsulation suggestion nit. Thank you. 🙌🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a
FormListboxWithGroupsfor the ecosystem project form.🛠️ Key Changes
components/Form/FormListboxWithGroups.tsxandcomponents/Form/ControlledFormListboxWithGroups.tsxcomponents/Listbox/ListboxOptionGroup.tsxfollowing the - https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-grouped/ecosystem-explorer/utils/getGroupedCategoryOptions.ts📌 To-Do Before Merging
📸 Screenshots
🔖 Resources