Capitalise Makefile filename #798
Conversation
|
Oh I'm not sure about this 😕 What apps are you trying to be consistent with? |
|
At least the 17 apps on which we are currently performing Page Kit migrations: #794. |
|
On the one hand, you've made a strong case for consistency! On the other, we don't use this capitalisation pattern for any other root-level files and I don't mind Page Kit breaking with conventions when we have a good reason to. On balance, I can reluctantly accept this based on the fact that it might improve usability, but I'd be interested to know why we capitalise the |
|
Seems the convention is to capitalise (although the reasoning for this comes from the handling of letter casing only on certain operating systems): https://stackoverflow.com/questions/14368941/is-the-convention-for-naming-make-files-to-use-a-capital-m-such-as-makefile/14368985 Having only ever seen it capitalised means my muscle memory kept missing it in lowercase, so this PR was made exclusively from a usability angle. Happy to merge or close either way. |
|
Agreed offline to close. |
I kept not being able to find the Makefile because I was looking for its name being capitalised.
This creates consistency with how it is written elsewhere throughout Customer Products.