Skip to content

Commit

Permalink
chore: remove node-fetch
Browse files Browse the repository at this point in the history
I'm not sure why we ever included this, we can just use the native fetch
method. It's fine as it's a test. This will reduce the number of
annoying dependency bump PRs we get.
  • Loading branch information
rowanmanning committed Jul 18, 2024
1 parent 05656f7 commit 5550254
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/middleware-log-errors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
},
"devDependencies": {
"@financial-times/n-express": "^31.8.0",
"@types/express": "^4.17.21",
"node-fetch": "^2.7.0"
"@types/express": "^4.17.21"
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const fetch = require('node-fetch');
const { fork } = require('node:child_process');

describe('@dotcom-reliability-kit/middleware-log-errors end-to-end', () => {
Expand Down

0 comments on commit 5550254

Please sign in to comment.